Skip to content

Commit

Permalink
Fix itest on py27
Browse files Browse the repository at this point in the history
The itest failure is due to a chain of dependencies that end up trying to
install more_itertools without specifying a version. `more_itertools`
dropped support for py27 with version 6.0.0, which causes failures when
trying to import it in a py27 environment with the same error as here:
pytest-dev/pytest#4770

Why did it start failing this week? It looks like our internal pypi:
https://pypi.yelpcorp.com/simple/more-itertools/ has only had up to
version 4.2.0 recently, and @drmorr uploaded a wheel for v7.2.0
yesterday, which the py27 acceptance test is trying to install. It looks
like the old version of pip we’re using, as described in that github issue,
is trying to install the latest version of more-itertools, despite itest
being marked as only for py3, and failing in the itest.
  • Loading branch information
dbgrigsby committed Aug 30, 2019
1 parent 4cf4500 commit 62c2271
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions requirements-dev.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ ipdb==0.10.3
ipython==4.2.0
ipython-genutils==0.1.0
mock
more-itertools==4.2.0
pre-commit==0.8.0
pytest==3.9.3
setuptools==40.0.0
Expand Down

0 comments on commit 62c2271

Please sign in to comment.