Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce proper framework metrics #381

Merged
merged 4 commits into from
May 10, 2022
Merged

Introduce proper framework metrics #381

merged 4 commits into from
May 10, 2022

Conversation

bitzl
Copy link
Member

@bitzl bitzl commented May 6, 2022

So far, Flusswerk defines two metrics out-of-the-box: total amount processed messages, and total time spent processing the message.

There are two issues with the current implementation:

  1. the names are not following Prometheus best practices
  2. framework metrics and user defined metrics share the same prefix as configured with flusswerk.monitoring.basename (default: "flusswerk")

This PR introduces two new metrics that are named independently from the value of basename and that follow best practices:

flusswerk_messages_total is the total number of messages processed since start of the application, flusswerk_processing_seconds the time spent on processing. Values from parallel threads are added up.

@bitzl bitzl marked this pull request as ready for review May 9, 2022 12:19
@bitzl bitzl marked this pull request as draft May 9, 2022 12:31
@bitzl bitzl marked this pull request as ready for review May 10, 2022 09:26
@bitzl bitzl merged commit a53a3c2 into main May 10, 2022
@bitzl bitzl deleted the fix-metrics branch May 10, 2022 12:14
@bitzl bitzl mentioned this pull request May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants