Introduce proper framework metrics #381
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, Flusswerk defines two metrics out-of-the-box: total amount processed messages, and total time spent processing the message.
There are two issues with the current implementation:
flusswerk.monitoring.basename
(default: "flusswerk")This PR introduces two new metrics that are named independently from the value of basename and that follow best practices:
flusswerk_messages_total
is the total number of messages processed since start of the application,flusswerk_processing_seconds
the time spent on processing. Values from parallel threads are added up.