This repository has been archived by the owner on Sep 20, 2023. It is now read-only.
Changed to used XDomainRequest only when url is cross domain #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some platforms produce frequent mousemove events whether or not the mouse has moved. This causes the UI to always be displayed since userActive_ is always `true`. By keeping track of the last mouse position and only firing if the new position is different, we can eleminate the event spam.
Conflicts: dist/video-js/video-js.css dist/video-js/video-js.min.css dist/video-js/video.js
Squashed commit of the following: commit 2c5d4d5 Author: Tom Johnson <[email protected]> Date: Tue Apr 1 15:02:37 2014 -0700 update control text for liveDisplay component commit 10f21cc Author: Tom Johnson <[email protected]> Date: Tue Apr 1 12:23:20 2014 -0700 whitespace fix commit 6a093d6 Author: Tom Johnson <[email protected]> Date: Tue Apr 1 12:21:42 2014 -0700 remove window scope of infinity commit 2dd8284 Author: Tom Johnson <[email protected]> Date: Tue Apr 1 12:12:13 2014 -0700 update to fix infinity capitalization. only do css logic on valid duration. set any duration of less than zero to window.Infinity commit f940bef Author: Tom Johnson <[email protected]> Date: Tue Apr 1 10:01:27 2014 -0700 update to less than zero on player durationChange commit 554c003 Author: Tom Johnson <[email protected]> Date: Mon Mar 31 17:26:13 2014 -0700 update exports, fix tests commit 2fb10cb Author: Tom Johnson <[email protected]> Date: Mon Mar 31 13:39:00 2014 -0700 fix tests, remove update display list in LiveDisplay commit bc47c5e Author: Tom Johnson <[email protected]> Date: Mon Mar 31 13:13:43 2014 -0700 Basic UI for Live
Included are two sanity check tests for the two areas being checked to make sure that the menu title items are being correctly placed in the actual UL element of the menu. Fixes videojs#1107
Squashed commit of the following: commit d5957da Author: David LaPalomento <[email protected]> Date: Mon Mar 31 16:22:43 2014 -0400 Peg the volume control to 1.0 on init Setup styles so that the volume control initially renders at full volume. This matches browser behavior where volume is available and saves Javascript from having to manually update the volume control on init. After the initial draw, the volume control is updated dynamically the same way it was before. commit 8bc861f Author: David LaPalomento <[email protected]> Date: Wed Mar 12 17:16:30 2014 -0400 Don't force sliders to get evaluated on load Since the load and play progress sliders are guaranteed to start from zero, set that through CSS. Calling Slider.prototype.update forces a re-flow because element dimensions are queried and style rules changed. That reflow consistently took around 60ms on my laptop which would mean dropped frames and "jerkiness" on initialization.
…deo.js into coursera-feature/fix-menu-title
small typo fix in code that leads to error
getElementsById -> getElementById
Conflicts: dist/video-js/video-js.css dist/video-js/video-js.min.css dist/video-js/video.js
…ff-feature/tech-error
…to heff-feature/tech-error
…owsers that also have JavaScript disabled
Conflicts: src/js/lib.js
Updates for videojs#1093
Included self-hosting MIME type instructions
Added a more explicit MIME type note in setup. Moved to a footnote and made comment more verbose to avoid confusion.
…js into dbmedialab-feature/IE-get-xDomain
Did some reorganization of the code.
floehopper
added a commit
to freerange/video-test
that referenced
this pull request
May 9, 2014
|
I've built a couple of pages to test this stuff out in my scenario where I have subtitles [1] on a different sub-domain. I have the code from the PR before [2] and after [3] your most recent changes. Unfortunately, the subtitles work OK before [2] the most recent changes, but not after [3]. It's really hard to debug in IE8 and I don't have much time at the moment, so I'm afraid I can't help diagnose the problem, but hopefully the test pages might be useful to you. [1] the subtitles don't match the video |
|
As an aside, I think it would be clearer if the PR just had only the commits that contain code changes rather than all these merge commits i.e. I'd be happy to make such a PR if you like. |
|
Yeah, it's a little bit of a mess as is, but I'm not sure of a better way to do that easily. I'm going to squash/rebase before merging this in either way, but if you think it'd be better to clean that up now please feel free. |
|
Also thanks for the examples. That might help figure things out. |
skogby
pushed a commit
that referenced
this pull request
May 12, 2014
Changed to used XDomainRequest only when url is cross domain Tested and it seems to be working, I currently don't have access to a IE9 computer though.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can you please test that this still works in your use case, and if it does, accept this pull request. Thanks!
-heff