Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Disforge #103

Merged
merged 2 commits into from
Jan 11, 2021
Merged

feat: add Disforge #103

merged 2 commits into from
Jan 11, 2021

Conversation

EndBug
Copy link
Member

@EndBug EndBug commented Jan 9, 2021

Ref #58

@EndBug EndBug added the type: feature New feature or feature request label Jan 9, 2021
@EndBug EndBug requested a review from Snazzah January 9, 2021 14:47
@EndBug EndBug self-assigned this Jan 9, 2021
@codecov
Copy link

codecov bot commented Jan 9, 2021

Codecov Report

Merging #103 (93ec470) into master (975132c) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
+ Coverage   96.05%   96.12%   +0.06%     
==========================================
  Files          45       46       +1     
  Lines        1218     1239      +21     
  Branches      178      178              
==========================================
+ Hits         1170     1191      +21     
  Misses         44       44              
  Partials        4        4              
Impacted Files Coverage Δ
src/Interface/Lists/Disforge.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88c4bac...93ec470. Read the comment docs.

Authorization: token
},
data: {
servers: Util.resolveCount(serverCount)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs don't say whether servers should be a payload property, a query parameter, or a header... I'm just going to assume it's the first, since my bot hasn't been approved yet.

@EndBug EndBug mentioned this pull request Jan 9, 2021
@EndBug EndBug merged commit c057871 into master Jan 11, 2021
@EndBug EndBug deleted the NS-df branch January 11, 2021 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant