Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TopGG): use authentication on every method #180

Merged
merged 5 commits into from
Mar 23, 2021
Merged

fix(TopGG): use authentication on every method #180

merged 5 commits into from
Mar 23, 2021

Conversation

EndBug
Copy link
Member

@EndBug EndBug commented Mar 22, 2021

A user has reported that TopGG responds with a 401 when the class methods are used, and I've been able to reproduce the issue. (We've only talked about userVoted, but I'll assume that it's required for each endpoint)
This should fix it, by requiring a token in every class method.

Fix #174

EndBug added 2 commits March 22, 2021 10:15
I've added authorization to every method, since it seems to solve the 401 error reported in issue #174
@EndBug EndBug added the type: bug Verified problems that need to be worked on label Mar 22, 2021
@EndBug EndBug requested a review from Snazzah March 22, 2021 09:22
@EndBug EndBug self-assigned this Mar 22, 2021
@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #180 (02aa7e8) into master (3e47c1a) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 02aa7e8 differs from pull request most recent head 01234c8. Consider uploading reports for the commit 01234c8 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #180   +/-   ##
=======================================
  Coverage   96.98%   96.98%           
=======================================
  Files          45       45           
  Lines        1196     1196           
  Branches      191      191           
=======================================
  Hits         1160     1160           
  Misses         32       32           
  Partials        4        4           
Impacted Files Coverage Δ
src/Interface/Lists/TopGG.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e47c1a...01234c8. Read the comment docs.

Copy link
Member

@Snazzah Snazzah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New API URL is now https://docs.top.gg/, should be changed in the docs. Everything else LGTM.

@EndBug EndBug requested a review from Snazzah March 22, 2021 20:02
@EndBug EndBug merged commit 068cb95 into master Mar 23, 2021
@EndBug EndBug deleted the U-topgg branch March 23, 2021 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Verified problems that need to be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue in getting votes - Top.gg
2 participants