Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add FatesList #186

Merged
merged 4 commits into from
Mar 30, 2021
Merged

feat: add FatesList #186

merged 4 commits into from
Mar 30, 2021

Conversation

EndBug
Copy link
Member

@EndBug EndBug commented Mar 27, 2021

@Snazzah I'm adding this service and I noticed they have a LOT of endpoints. Do you want to add all of them?
(It's not an issue if you want to, I just want to be sure before I start adding them)

Docs: https://fateslist.xyz/api/docs/endpoints#tag/API

@EndBug EndBug added the type: feature New feature or feature request label Mar 27, 2021
@EndBug EndBug self-assigned this Mar 27, 2021
@codecov
Copy link

codecov bot commented Mar 27, 2021

Codecov Report

Merging #186 (282edef) into master (2be800d) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #186      +/-   ##
==========================================
+ Coverage   97.67%   97.79%   +0.11%     
==========================================
  Files          45       46       +1     
  Lines        1205     1270      +65     
  Branches      192      194       +2     
==========================================
+ Hits         1177     1242      +65     
  Misses         27       27              
  Partials        1        1              
Impacted Files Coverage Δ
src/Interface/Lists/FatesList.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2be800d...282edef. Read the comment docs.

@Snazzah
Copy link
Member

Snazzah commented Mar 27, 2021

I'm alright with adding these.

@EndBug EndBug marked this pull request as ready for review March 29, 2021 07:17
@EndBug EndBug requested a review from Snazzah March 29, 2021 07:17
@EndBug EndBug merged commit 4f7fed1 into master Mar 30, 2021
@EndBug EndBug deleted the N-fateslist branch March 30, 2021 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants