-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: remove serviceClasses #203
Conversation
BREAKING CHANGE: serviceClasses will no longer be an exported member of the package.
Codecov Report
@@ Coverage Diff @@
## master #203 +/- ##
==========================================
+ Coverage 97.80% 97.85% +0.05%
==========================================
Files 46 47 +1
Lines 1275 1307 +32
Branches 196 196
==========================================
+ Hits 1247 1279 +32
Misses 27 27
Partials 1 1
Continue to review full report at Codecov.
|
Should there be a way for TypeScript users to get the types for service classes and not necessarily get the class itself from the index? There might be a way to define overrides for |
Hmmmm, you're right, I didn't think about that... |
Ok, so here's what I've changed. The file is not automatically updated in the build script, to avoid unintentional changes being pushed: the What do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit awkward, but the result works well.
Ref #58
After this PR is merged,
serviceClasses
will no longer be exported, even though it'll still be accessible viaService.getAll()
. This is to encourage users to get service classes usingService.get()
with aliases, instead of relying on internal class names.From now on, changes to internal class names should not be marked as breaking changes, since the intended way of getting them is through aliases.