Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: remove dead services #204

Merged
merged 4 commits into from
Apr 8, 2021
Merged

fix!: remove dead services #204

merged 4 commits into from
Apr 8, 2021

Conversation

EndBug
Copy link
Member

@EndBug EndBug commented Apr 8, 2021

Removed lists:

  • BotsDataBase
  • DiscordAppsDev
  • DiscordBotsDirectory
  • ListMyBots
  • ParadiseBots
  • Arcane

Arcane has been down for almost a month, even if they said the project is just "paused". Should I keep it? @Snazzah

@EndBug EndBug added the type: fix Updates to existing functionalities label Apr 8, 2021
@EndBug EndBug self-assigned this Apr 8, 2021
@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #204 (c246f5c) into master (d8f9e16) will decrease coverage by 0.26%.
The diff coverage is n/a.

❗ Current head c246f5c differs from pull request most recent head becf560. Consider uploading reports for the commit becf560 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
- Coverage   97.85%   97.59%   -0.27%     
==========================================
  Files          47       41       -6     
  Lines        1307     1162     -145     
  Branches      196      189       -7     
==========================================
- Hits         1279     1134     -145     
  Misses         27       27              
  Partials        1        1              
Impacted Files Coverage Δ
src/Interface/ListIndex.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8f9e16...becf560. Read the comment docs.

Copy link
Member

@Snazzah Snazzah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you should delete Arcane.

@EndBug EndBug merged commit cdff1a6 into master Apr 8, 2021
@EndBug EndBug deleted the dead-services branch April 8, 2021 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: fix Updates to existing functionalities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants