Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build for OSX + Node 12 #6

Merged
merged 5 commits into from
Jan 3, 2021
Merged

Fix build for OSX + Node 12 #6

merged 5 commits into from
Jan 3, 2021

Conversation

szymonWojdat
Copy link
Contributor

  • remove sem_getvalue calls
  • update to newest version of nan API

closes #5

dbousque
dbousque reviewed Jan 3, 2021
View reviewed changes
Copy link
Owner

@dbousque dbousque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Just a few things need to be cleared.

srcs/semaphore.cc Show resolved Hide resolved
srcs/semaphore.cc Show resolved Hide resolved
srcs/semaphore.cc Show resolved Hide resolved
srcs/semaphore.cc Outdated Show resolved Hide resolved
srcs/semaphore.cc Outdated Show resolved Hide resolved
dbousque
dbousque reviewed Jan 3, 2021
View reviewed changes
srcs/semaphore.cc Outdated Show resolved Hide resolved
dbousque
dbousque reviewed Jan 3, 2021
View reviewed changes
srcs/semaphore.cc Outdated Show resolved Hide resolved
dbousque
dbousque reviewed Jan 3, 2021
View reviewed changes
srcs/semaphore.cc Outdated Show resolved Hide resolved
@szymonWojdat
Copy link
Contributor Author

Thanks for taking a look so quickly. Adjusted as per comments.

@dbousque dbousque merged commit 5c2f766 into dbousque:master Jan 3, 2021
@dbousque
Copy link
Owner

dbousque commented Jan 3, 2021

Thanks @szymonWojdat !

@szymonWojdat
Copy link
Contributor Author

@dbousque FYI i just noticed that the build has failed, i think it didn't even manage to pull the code properly https://travis-ci.org/github/dbousque/posix-semaphore/jobs/752659175

@dbousque
Copy link
Owner

dbousque commented Jan 3, 2021

Thanks, I fixed it in master and deployed the new version as 1.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbousque dbousque dbousque left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing to build
2 participants
@szymonWojdat @dbousque