-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scan operator #30
Scan operator #30
Conversation
Forgot to reference the issue #29. |
PS: looks good. I'm making another PR to update black and pyright that should fix build issues. |
I suggest you to use pre-commit-ci and dependabot for these. |
Thanks for the suggestion. Looks like both |
Please try to merge master and build again. Note that you may also want to use |
Hello @dbrattli Sorry, I had too much work and didn't see your comment. Here is the merge commit. |
Thanks for the suggestions @dbrattli, it is a cleaner solution. Co-authored-by: Dag Brattli <[email protected]>
Hello @dbrattli, The pre-commit pyright hook fails under python 3.10. Cheers, |
Very nice. Looks good! |
Hello,
Here is the scan operator implementation.
I've included the sync and async variants.
The reduce depends on the code on this PR.
Some tests are missing too.
Please review this and post your thoughts.