Add null equality condition to equals macro #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bt-adapters into fix_null_equality_110
…bt-adapters into fix_null_equality_110
…null_equality_condition_to_equals_macro
VersusFacit
had a problem deploying
to
dbt-athena
GitHub Actions
Error
VersusFacit
had a problem deploying
to
dbt-athena
GitHub Actions
Error
VersusFacit
had a problem deploying
to
dbt-athena
GitHub Actions
Error
VersusFacit
had a problem deploying
to
dbt-athena
GitHub Actions
Error
VersusFacit
had a problem deploying
to
dbt-athena
GitHub Actions
Error
VersusFacit
had a problem deploying
to
dbt-athena
GitHub Actions
Error
VersusFacit
had a problem deploying
to
dbt-athena
GitHub Actions
Error
VersusFacit
had a problem deploying
to
dbt-athena
GitHub Actions
Error
VersusFacit
had a problem deploying
to
dbt-bigquery
GitHub Actions
Error
VersusFacit
temporarily deployed
to
dbt-snowflake
GitHub Actions
Inactive
VersusFacit
temporarily deployed
to
dbt-snowflake
GitHub Actions
Inactive
|
|
||
| {% macro default__equals(expr1, expr2) -%} | ||
| {%- if adapter.behavior.enable_truthy_nulls_equals_macro.no_warn %} | ||
| case when (({{ expr1 }} = {{ expr2 }}) or ({{ expr1 }} is null and {{ expr2 }} is null)) |
There was a problem hiding this comment.
next year we'll enable "extra truthy" nulls and support or ({{ expr1 }}= '' and {{ expr2 }} is null)
| body: Added new equals macro that handles null value checks in sql | ||
| time: 2024-12-17T11:05:36.363421+02:00 | ||
| custom: | ||
| Author: adrianburusdbt |
There was a problem hiding this comment.
@VersusFacit don't forget to add yourself as an author as well
Also not sure this is "under the hood" as we're making a meaningful improvement to how snapshots/tests work
colin-rogers-dbt
approved these changes
Jan 28, 2025
mikealfare
pushed a commit
that referenced
this pull request
Jan 29, 2025
* TableLastModifiedMetadataBatch capability * pin ddtrace * open connection before calculate_freshness_from_metadata_batch * remove calculate_freshness_from_metadata_batch override * changelog entry * TestGetLastRelationModifiedBatch * restore dev-requirements.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #110
followup to #383 #394
Note: still needs the athena test skip fix to be merged into main
Problem
We need to add the capability for the
equalsmacro to way the presence of no values. However, this is a huge blast radius and doesn't suit all use cases. So we'd like to add it behind a behavior flag and through customer use of this different behavior determine in the future what would be a better long-term solution while also delivering the customer value we need now. A complete solution will require far more investigation outside of this effort.Solution
The equals macro can be configured at the
dbt_project.ymllevel. Special attention is given to bigquery tests in this poor request because turning this flag on or off results in many errors across our current tests. This macro does not play well with sophisticated partitioning. A follow on snowflake PR is coming that will make use of this behavior and test it even more thoroughly.Checklist