Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add macros and adapter test for new dbt_clone flag #784

Merged
merged 10 commits into from
Jul 11, 2023

Conversation

McKnight-42
Copy link
Contributor

@McKnight-42 McKnight-42 commented Jun 22, 2023

resolves #785

Description

bigquery adapter part of dbt-labs/dbt-core#7881

Checklist

@McKnight-42 McKnight-42 self-assigned this Jun 22, 2023
@McKnight-42 McKnight-42 requested a review from a team as a code owner June 22, 2023 16:35
@McKnight-42 McKnight-42 requested a review from mikealfare June 22, 2023 16:35
@cla-bot cla-bot bot added the cla:yes label Jun 22, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide.

Copy link
Member

@aranke aranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, verify that the cloned tables/views are 0 bytes.

@McKnight-42
Copy link
Contributor Author

McKnight-42 commented Jun 30, 2023

ran the dbt clone command and checked otherschema to look at bytest generated by new table
original table
Screenshot 2023-06-30 at 1 45 10 PM

checking the cloned table details section does show the expected Base Table Info section

@mikealfare mikealfare requested a review from a team July 5, 2023 18:13
@McKnight-42 McKnight-42 merged commit 3c34dbb into main Jul 11, 2023
@McKnight-42 McKnight-42 deleted the feature/dbt-clone-bq branch July 11, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADAP-650] [Feature] dbt-bigquery Cloning from production
3 participants