Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower bound of 2.11.0 for google-api-core #980

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

dbeatty10
Copy link
Contributor

resolves #979

Problem

we import POLLING_PREDICATE from google.api_core.future.polling but google.api_core.future.polling.POLLING_PREDICATE is available on google-api-core version 2.11.0+.

Solution

ensure that this version is enforced and create a pin

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run @gmyrianthous ran this code in development and it appears to resolve the stated issue
  • Tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc)

@mikealfare
Copy link
Contributor

The integration tests did not run since this is only a change to setup.py (we need to fix this). I kicked them off manually here: https://github.com/dbt-labs/dbt-bigquery/actions/runs/6645236952

@dbeatty10
Copy link
Contributor Author

The integration tests did not run since this is only a change to setup.py (we need to fix this). I kicked them off manually here: https://github.com/dbt-labs/dbt-bigquery/actions/runs/6645236952

@mikealfare Opened this issue as a result: #982

Feel free to change the description, etc. or to transfer to a different repo as-needed.

@mikealfare
Copy link
Contributor

Adapter Integration Tests passed

@mikealfare mikealfare merged commit f0f6d14 into main Oct 25, 2023
@mikealfare mikealfare deleted the dbeatty/google-api-core-lower-bound branch October 25, 2023 22:23
github-actions bot pushed a commit that referenced this pull request Oct 27, 2023
* Lower bound of `2.11.0` for `google-api-core`

* Changelog entry

(cherry picked from commit f0f6d14)
github-actions bot pushed a commit that referenced this pull request Oct 27, 2023
* Lower bound of `2.11.0` for `google-api-core`

* Changelog entry

(cherry picked from commit f0f6d14)
mikealfare pushed a commit that referenced this pull request Oct 27, 2023
* Lower bound of `2.11.0` for `google-api-core`

* Changelog entry

(cherry picked from commit f0f6d14)

Co-authored-by: Doug Beatty <[email protected]>
mikealfare pushed a commit that referenced this pull request Oct 27, 2023
* Lower bound of `2.11.0` for `google-api-core`

* Changelog entry

(cherry picked from commit f0f6d14)

Co-authored-by: Doug Beatty <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants