Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine support for classmethods in record/replay #243

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

peterallenwebb
Copy link
Contributor

Description

Overridden classmethods were not recorded correctly, which these changes fix and test.

Checklist

@peterallenwebb peterallenwebb requested a review from a team as a code owner February 4, 2025 21:03
@cla-bot cla-bot bot added the cla:yes label Feb 4, 2025
Copy link

github-actions bot commented Feb 4, 2025

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.83%. Comparing base (3956ae7) to head (7f532ab).

Files with missing lines Patch % Lines
dbt_common/record.py 85.71% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #243      +/-   ##
==========================================
+ Coverage   69.66%   69.83%   +0.16%     
==========================================
  Files          52       52              
  Lines        3511     3517       +6     
==========================================
+ Hits         2446     2456      +10     
+ Misses       1065     1061       -4     
Flag Coverage Δ
unit 69.83% <86.66%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!! Thanks!!

@peterallenwebb peterallenwebb added this pull request to the merge queue Feb 5, 2025
Merged via the queue into main with commit 397fb3f Feb 5, 2025
15 checks passed
@peterallenwebb peterallenwebb deleted the paw/record_classmethods branch February 5, 2025 15:22
@peterallenwebb peterallenwebb restored the paw/record_classmethods branch February 7, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants