fix partial parsing of versioned models - schedule child nodes if lat…

…est version has been modified (#7439) (#7460) (cherry picked from commit 2739d5f) Co-authored-by: Michelle Ark <[email protected]>
dbt-labs · Apr 25, 2023 · 77867d7 · 77867d7
1 parent 1da608f
commit 77867d7
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 8 deletions.
diff --git a/.changes/unreleased/Fixes-20230424-164649.yaml b/.changes/unreleased/Fixes-20230424-164649.yaml
@@ -0,0 +1,6 @@
+kind: Fixes
+body: Fix partial parsing of latest_version changes for downstream references
+time: 2023-04-24T16:46:49.721231-04:00
+custom:
+  Author: MichelleArk
+  Issue: "7369"
diff --git a/core/dbt/parser/partial.py b/core/dbt/parser/partial.py
@@ -851,6 +851,9 @@ def delete_schema_mssa_links(self, schema_file, dict_key, elem):
                     if self.saved_files[file_id]:
                         source_file = self.saved_files[file_id]
                         self.add_to_pp_files(source_file)
+                    # if the node's latest version has changed - need to reparse all referencing nodes to ensure correct ref resolution
+                    if node.is_versioned and node.latest_version != elem.get("latest_version"):
+                        self.schedule_referencing_nodes_for_parsing(elem_unique_id)
             # remove from patches
             schema_file.node_patches.remove(elem_unique_id)
 

diff --git a/test/unit/utils.py b/test/unit/utils.py
@@ -336,11 +336,7 @@ def MockNode(package, name, resource_type=None, **kwargs):
 
     version = kwargs.get("version")
     search_name = name if version is None else f"{name}.v{version}"
-    unique_id = (
-        f"{str(resource_type)}.{package}.{name}"
-        # if version is None
-        # else f"{str(resource_type)}.{package}.{name}.v{version}"
-    )
+    unique_id = f"{str(resource_type)}.{package}.{name}"
     node = mock.MagicMock(
         __class__=cls,
         resource_type=resource_type,

diff --git a/tests/functional/partial_parsing/test_partial_parsing.py b/tests/functional/partial_parsing/test_partial_parsing.py
@@ -304,36 +304,43 @@ def models(self):
         return {
             "model_one.sql": model_one_sql,
             "model_one_v2.sql": model_one_sql,
+            "model_one_downstream.sql": model_four2_sql,
             "schema.yml": models_versions_schema_yml,
         }
 
     def test_pp_versioned_models(self, project):
         results = run_dbt(["run"])
-        assert len(results) == 2
+        assert len(results) == 3
 
         manifest = get_manifest(project.project_root)
         model_one_node = manifest.nodes["model.test.model_one.v1"]
         assert not model_one_node.is_latest_version
         model_two_node = manifest.nodes["model.test.model_one.v2"]
         assert model_two_node.is_latest_version
+        # assert unpinned ref points to latest version
+        model_one_downstream_node = manifest.nodes["model.test.model_one_downstream"]
+        assert model_one_downstream_node.depends_on.nodes == ["model.test.model_one.v2"]
 
         # update versions schema.yml block - latest_version from 2 to 1
         write_file(
             models_versions_updated_schema_yml, project.project_root, "models", "schema.yml"
         )
         results = run_dbt(["--partial-parse", "run"])
-        assert len(results) == 2
+        assert len(results) == 3
 
         manifest = get_manifest(project.project_root)
         model_one_node = manifest.nodes["model.test.model_one.v1"]
         assert model_one_node.is_latest_version
         model_two_node = manifest.nodes["model.test.model_one.v2"]
         assert not model_two_node.is_latest_version
+        # assert unpinned ref points to latest version
+        model_one_downstream_node = manifest.nodes["model.test.model_one_downstream"]
+        assert model_one_downstream_node.depends_on.nodes == ["model.test.model_one.v1"]
 
         # update versioned model
         write_file(model_two_sql, project.project_root, "models", "model_one_v2.sql")
         results = run_dbt(["--partial-parse", "run"])
-        assert len(results) == 2
+        assert len(results) == 3
 
 
 class TestSources: