Merge pull request #2513 from southpolemonkey/dev/marian-anderson

(#2511) Remove log messages about opening connections in set_connecti…
dbt-labs · Jun 8, 2020 · f3565f3 · f3565f3
2 parents 05634e6 + 2be7ee6
commit f3565f3
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,11 +8,13 @@
 
 ### Fixes
 - Fixed an error in create_adapter_plugins.py script when -dependency arg not passed ([#2507](https://github.com/fishtown-analytics/dbt/issues/2507), [#2508](https://github.com/fishtown-analytics/dbt/pull/2508))
+- Remove misleading "Opening a new connection" log message in set_connection_name. ([#2511](https://github.com/fishtown-analytics/dbt/issues/2511))
 
 Contributors:
  - [@raalsky](https://github.com/Raalsky) ([#2417](https://github.com/fishtown-analytics/dbt/pull/2417), [#2485](https://github.com/fishtown-analytics/dbt/pull/2485))
  - [@alf-mindshift](https://github.com/alf-mindshift) ([#2431](https://github.com/fishtown-analytics/dbt/pull/2431))
  - [@scarrucciu](https://github.com/scarrucciu) ([#2508](https://github.com/fishtown-analytics/dbt/pull/2508))
+- [@southpolemonkey](https://github.com/southpolemonkey)([#2511](https://github.com/fishtown-analytics/dbt/issues/2511)) 
 
 ## dbt 0.17.0 (Release TBD)
 

diff --git a/core/dbt/adapters/base/connections.py b/core/dbt/adapters/base/connections.py
@@ -139,10 +139,6 @@ def set_connection_name(self, name: Optional[str] = None) -> Connection:
                 .format(conn.name)
             )
         else:
-            logger.debug(
-                'Opening a new connection, currently in state {}'
-                .format(conn.state)
-            )
             conn.handle = LazyHandle(self.open)
 
         conn.name = conn_name

diff --git a/core/dbt/contracts/connection.py b/core/dbt/contracts/connection.py
@@ -15,6 +15,8 @@
 from dbt.exceptions import InternalException
 from dbt.utils import translate_aliases
 
+from dbt.logger import GLOBAL_LOGGER as logger
+
 
 Identifier = NewType('Identifier', str)
 register_pattern(Identifier, r'^[A-Za-z_][A-Za-z0-9_]+$')
@@ -87,6 +89,10 @@ def __init__(self, opener: Callable[[Connection], Connection]):
         self.opener = opener
 
     def resolve(self, connection: Connection) -> Connection:
+        logger.debug(
+            'Opening a new connection, currently in state {}'
+            .format(connection.state)
+        )
         return self.opener(connection)