Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbt --version should handle alpha releases gracefully #557

Closed
jthandy opened this issue Oct 11, 2017 · 2 comments
Closed

dbt --version should handle alpha releases gracefully #557

jthandy opened this issue Oct 11, 2017 · 2 comments
Labels
good_first_issue Straightforward + self-contained changes, good for new contributors!

Comments

@jthandy
Copy link
Member

jthandy commented Oct 11, 2017

This is obviously not correct :)

λ dbt --version
installed version: 0.9.0a1
   latest version: 0.8.3
Your version of dbt is out of date! You can find instructions
    for upgrading here:

    https://dbt.readme.io/docs/installation
@drewbanin drewbanin added the good_first_issue Straightforward + self-contained changes, good for new contributors! label Oct 28, 2017
@mturzanska
Copy link
Contributor

@drewbanin correct my if I'm wrong (very likely):

  • the above version mismatch was caused by .bumpversion.cfg not being updated
  • the real issue is the regex in __parse_version that leaves out letters

@drewbanin
Copy link
Contributor

Hey @mturzanska - I generally think dbt should handle versions a little better/smarter. Right now, dbt --version will check if the local version == the remote version (on Github master). If the versions are not equal, then dbt says "your version is out of date".

So yeah, part of this is improving the regex, and part is just tweaking the ux a little. Ideally, dbt would say something more helpful, or nothing, when you're ahead of master.

@drewbanin drewbanin reopened this Nov 10, 2017
drewbanin added a commit that referenced this issue Jun 18, 2018
iknox-fa pushed a commit that referenced this issue Feb 8, 2022
* Allow for more complex version comparison

Allow for letters in version names
Add tests for version info

* Fix integration tests

* Combine code from @mturzanska's PR with development

Based on: #577
Fixes: #557


automatic commit by git-black, original commits:
  d28407d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good_first_issue Straightforward + self-contained changes, good for new contributors!
Projects
None yet
Development

No branches or pull requests

3 participants