Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-1618] [Feature] Metric timestamp and time_grains should be optional #6398

Closed
3 tasks done
callum-mcdata opened this issue Dec 6, 2022 · 0 comments · Fixed by #6402
Closed
3 tasks done

[CT-1618] [Feature] Metric timestamp and time_grains should be optional #6398

callum-mcdata opened this issue Dec 6, 2022 · 0 comments · Fixed by #6402
Labels
enhancement New feature or request semantic Issues related to the semantic layer

Comments

@callum-mcdata
Copy link
Contributor

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion

Describe the feature

In today's world, we state that dbt metrics are inherently time bound - they must be associated with a timestamp and any query of them is aggregated at the grain provided. This was initially bound with #6379 but this is actually something we can pursue before beginning that work - they're not bound to one another.

scratch oh wait that's not entirely true 😅

Based on feedback, we implemented a feature in the metrics package to support the 'all_time' grain where we aggregate to the base grain of the metric. So we already support a world where timestamp isn't really needed.

Additionally we have derived metrics which don't need timestamps because they combine the timestamps of other metrics.

So lets support this world we've created!

The Proposal

  • timestamp becomes an optional input
  • time_grains becomes an optional input
  • Rewrite dbt_metrics to make grain an optional input and the base behavior is all time. This will follow in another issue.

Describe alternatives you've considered

Not doing this but we already "support" it!

Who will this benefit?

Anyone who uses metrics but doesn't want to aggregate them by time!

Are you interested in contributing this feature?

You betcha!

Anything else?

No response

@callum-mcdata callum-mcdata added enhancement New feature or request triage labels Dec 6, 2022
@github-actions github-actions bot changed the title [Feature] Metric timestamp and time_grains should be optional [CT-1618] [Feature] Metric timestamp and time_grains should be optional Dec 6, 2022
@jtcohen6 jtcohen6 removed the 1.4.0 label Jan 4, 2023
@jtcohen6 jtcohen6 added the semantic Issues related to the semantic layer label Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request semantic Issues related to the semantic layer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants