-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making Metric Timestamps Optional #6402
Conversation
@callum-mcdata I think this requires an update to docs (for v1.4+), since we currently say that |
@jtcohen6 yep! I've got it on my to-do - we're going to mirror the readme in dbt_metrics over to the docs page so people don't need to reference two locations. |
@jtcohen6 if you're curious here is the PR for updating the docs |
@callum-mcdata You're the best! Was just reviewing this morning to make sure we're not missing any relevant docs updates |
resolves #6398
Description
This makes the timestamp property optional. This is in order to support non time-grain behavior in dbt_metrics. PR here: dbt-labs/dbt_metrics#204
Concrete changes:
Checklist
changie new
to create a changelog entry