Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbt-docs changes for v0.18.0 (final) #2734

Merged
merged 2 commits into from
Sep 1, 2020

Conversation

jtcohen6
Copy link
Contributor

@jtcohen6 jtcohen6 commented Sep 1, 2020

resolves #2705 (again), follow-up to #2715

Description

  • Final docs change for v0.18.0: support for displaying project-level overview pages. I've tested this locally, it's additive only, I just need to document it
  • Add changelog entry for docs#121. This change was included in the RC, but I missed it in the changelog when I retroactively wrote up the changes in Docs site updates for 0.18.0 #2715. The remedy here is that each PR to the dbt-docs repo will be required to add its own changelog entry in that repo. I will cut releases in that repo, then open PRs (like this one) to port over the changes + changelog.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@jtcohen6 jtcohen6 requested a review from beckjake September 1, 2020 19:13
@cla-bot cla-bot bot added the cla:yes label Sep 1, 2020
Copy link
Contributor

@beckjake beckjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, though obviously I have not examined the contents of index.html

@jtcohen6 jtcohen6 merged commit 981535a into dev/marian-anderson Sep 1, 2020
@jtcohen6 jtcohen6 deleted the docs/0.18.0-followup branch September 1, 2020 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs changes for 0.18.0
2 participants