feat: allow nested YAML in profile templates #4466
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
I do like the flexibility that this would offer and it definitely resolves the issue you raised! Will leave a comment around making this more interactive on the issue. |
Comment on lines
+62
to
+63
| if isinstance(value, str): | ||
| return yaml.safe_load(value) |
There was a problem hiding this comment.
If value is an empty string, yaml.safe_load will return None. I'm pointing it out because we had a previous production bug because of this. Not sure how the click library handles None values.
|
This PR has been marked as Stale because it has been open for 180 days with no activity. If you would like the PR to remain open, please remove the stale label or comment on the PR, or it will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4462
Description
Allow YAML objects and arrays to be parsed from user input or passed directly from default values in order to fill the target profile.
Checklist
CHANGELOG.mdand added information about my change