-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding perf testing GHA #5851
Adding perf testing GHA #5851
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we only run against main
? When we release 1.2.7
it could have significantly diverged from main
.
|
the model action should be pulling the action code from |
|
||
# `${{ github.workspace }}` is used to pass the absolute path | ||
# TODO CHANGE NUMBER OF RUNS BEFORE MERGING | ||
# TODO this isn't putting the baseline in the right directory. it's putting it one level up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nathaniel-may do you remember what this comment meant? It looks like the PR shows the file is in the right directory
@emmyoop @nathaniel-may could I get a look at this again please? I do want to get these times documented for all the 1.0+ versions as we get further away from 1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just updating to use the new env variable for outputs everywhere but nothing else jumps out.
This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. There are several "remove/change before merging" comments to take care of before merging.
resolves #4021
Description
This PR creates an Action that automates running our perf regression testing framework after a release. It also reports those results and creates a PR for them so we can continue to keep track of the numbers over time
I pulled this work out of this draft PR #4872 and just targeted the single action to gather results after a release is made (the other action is out of scope for this)
Example PRs created here
Checklist
changie new
to create a changelog entry