Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dmypy cache to gitignore #5978

Merged
merged 4 commits into from
Oct 10, 2022
Merged

Add dmypy cache to gitignore #5978

merged 4 commits into from
Oct 10, 2022

Conversation

max-sixty
Copy link
Contributor

@max-sixty max-sixty commented Sep 30, 2022 •
edited by lostmygithubaccount
Loading

Do I need to open an issue for this? Stub issue: fixes #6028

Description

Checklist

@max-sixty max-sixty requested a review from a team as a code owner September 30, 2022 21:31
@cla-bot cla-bot bot added the cla:yes label Sep 30, 2022
@max-sixty max-sixty mentioned this pull request Oct 2, 2022
Open
6 tasks
@max-sixty max-sixty mentioned this pull request Oct 7, 2022
Closed
3 tasks
lostmygithubaccount
lostmygithubaccount reviewed Oct 7, 2022
View reviewed changes
.gitignore
@@ -24,7 +24,8 @@ var/
*.egg-info/
.installed.cfg
*.egg
*.mypy_cache/
.mypy_cache/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is removing the asterisk here intentional?

Copy link
Contributor Author

@max-sixty max-sixty Oct 8, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partly — I copied and pasted it along with line below. The * isn't doing anything; it's a dotfile rather than an extension. It's not doing anything bad though, fine to revert if easier to review

@lostmygithubaccount lostmygithubaccount added the ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering label Oct 7, 2022
@emmyoop emmyoop merged commit dc96352 into dbt-labs:main Oct 10, 2022
@max-sixty max-sixty deleted the gitignore branch October 10, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lostmygithubaccount lostmygithubaccount lostmygithubaccount left review comments

@emmyoop emmyoop emmyoop approved these changes

@gshank gshank Awaiting requested review from gshank gshank was automatically assigned from dbt-labs/core-group

@McKnight-42 McKnight-42 Awaiting requested review from McKnight-42 McKnight-42 was automatically assigned from dbt-labs/core-group

Assignees
No one assigned
Labels
cla:yes ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-1314] [Internal] Add dmypy cache to gitignore
3 participants
@max-sixty @emmyoop @lostmygithubaccount