-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add -f for seeds #5991
Merged
Merged
add -f for seeds #5991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
gshank
approved these changes
Oct 3, 2022
lostmygithubaccount
added
ready_for_review
Externally contributed PR has functional approval, ready for code review from Core engineering
support_rotation
A good task to pick up during support rotation
labels
Oct 4, 2022
@jtcohen6 would we want this in the 1.3 release? |
@leahwicz Not worth the hassle / risk of backporting IMO. It will be good to have some exciting user-facing functionality in v1.4! Or we could include in the v1.3.1 patch if needed. |
emmyoop
requested changes
Oct 5, 2022
Co-authored-by: Emily Rockman <[email protected]>
emmyoop
approved these changes
Oct 5, 2022
Thanks @dave-connors-3! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cla:yes
ready_for_review
Externally contributed PR has functional approval, ready for code review from Core engineering
support_rotation
A good task to pick up during support rotation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5990
Description
Seeds need
-f
too!Checklist
changie new
to create a changelog entry