Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Fix the partial parse write path #6081

Merged
merged 5 commits into from
Dec 2, 2022
Merged

[fix] Fix the partial parse write path #6081

merged 5 commits into from
Dec 2, 2022

Conversation

z3z1ma
Copy link
Contributor

@z3z1ma z3z1ma commented Oct 17, 2022

resolves #6055

Partial parse should use project root or it does not resolve to correct path.
Eg. target-path: ../some/dir/target, if not ran from root, creates an erroneous folder.

Checklist

Partial parse should use project root or it does not resolve to correct path. 
Eg. `target-path: ../some/dir/target`, if not ran from root, creates an erroneous folder.
@z3z1ma z3z1ma requested a review from a team as a code owner October 17, 2022 18:59
@z3z1ma z3z1ma requested a review from peterallenwebb October 17, 2022 18:59
@cla-bot
Copy link

cla-bot bot commented Oct 17, 2022

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @z3z1ma

@z3z1ma
Copy link
Contributor Author

z3z1ma commented Oct 17, 2022

Signed

Please label this hackathon, lets go haha

@emmyoop emmyoop added the Hackathon Coalesce Hackathon Submissions label Oct 17, 2022
@leahwicz leahwicz requested a review from gshank October 17, 2022 20:19
@cla-bot cla-bot bot added the cla:yes label Oct 20, 2022
Copy link
Contributor

@gshank gshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is fine :). But it needs to have "pre-commit run --all-files" run to fix the formatting issue (pip install pre-commit if you don't have it installed), and run "changie new" to create a changelog entry.

@jtcohen6
Copy link
Contributor

Yo @z3z1ma, great to see you hacking in here! :)

Are you up to fix the pre-commit checks and add a changelog entry?

@jtcohen6 jtcohen6 added Team:Language ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering labels Nov 17, 2022
@z3z1ma
Copy link
Contributor Author

z3z1ma commented Nov 18, 2022

Yeah for sure. Will get to it this weekend :)

@frannydelaney
Copy link

Oo I need this :)

@derek-hackett-procore
Copy link

Same here

@gshank gshank requested a review from a team as a code owner December 2, 2022 21:50
@gshank gshank merged commit 67a8138 into dbt-labs:main Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Hackathon Coalesce Hackathon Submissions ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering
Projects
None yet
6 participants