-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] Fix the partial parse write path #6081
Conversation
Partial parse should use project root or it does not resolve to correct path. Eg. `target-path: ../some/dir/target`, if not ran from root, creates an erroneous folder.
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin. CLA has not been signed by users: @z3z1ma |
Signed Please label this hackathon, lets go haha |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change is fine :). But it needs to have "pre-commit run --all-files" run to fix the formatting issue (pip install pre-commit if you don't have it installed), and run "changie new" to create a changelog entry.
Yo @z3z1ma, great to see you hacking in here! :) Are you up to fix the pre-commit checks and add a changelog entry? |
Yeah for sure. Will get to it this weekend :) |
Oo I need this :) |
Same here |
resolves #6055
Partial parse should use project root or it does not resolve to correct path.
Eg.
target-path: ../some/dir/target
, if not ran from root, creates an erroneous folder.Checklist
changie new
to create a changelog entry