Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated set-output commands #6152

Closed
wants to merge 3 commits into from
Closed

Fix deprecated set-output commands #6152

wants to merge 3 commits into from

Conversation

kevinneville
Copy link
Contributor

@kevinneville kevinneville commented Oct 26, 2022

resolves #6153

Description

As communicated by Github in https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ these commands should be replaced.

Checklist

@leahwicz leahwicz requested review from emmyoop and removed request for peterallenwebb October 27, 2022 00:46
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @kevinneville! I've left some suggested changes for you.

.changes/unreleased/Fixes-20221027-001848.yaml Outdated Show resolved Hide resolved
.github/workflows/release-docker.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/release-docker.yml Outdated Show resolved Hide resolved
.github/workflows/version-bump.yml Outdated Show resolved Hide resolved
.github/actions/latest-wrangler/main.py Outdated Show resolved Hide resolved
@kevinneville kevinneville requested a review from emmyoop October 27, 2022 16:17
@lostmygithubaccount lostmygithubaccount added the ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering label Oct 27, 2022
Copy link
Contributor

@stu-k stu-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just another double quote change, otherwise looks good!

.github/workflows/release-docker.yml Outdated Show resolved Hide resolved
@kevinneville kevinneville requested review from stu-k and emmyoop and removed request for emmyoop and stu-k November 10, 2022 20:44
Copy link
Contributor

@leahwicz leahwicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinneville this LGTM and thank you so much for taking the time to fix this in multiple repos. Could you do us one last favor and update your branch to reflect the latest main changes please? CI is failing from a change made to a dependency that we have fixed in that branch already

@jtcohen6
Copy link
Contributor

Resolved by #6635

@jtcohen6 jtcohen6 closed this Jan 18, 2023
@emmyoop emmyoop mentioned this pull request May 12, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-1416] [Bug] GitHub Actions: Deprecating save-state and set-output commands
6 participants