-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add adapter_response for test #6645
Conversation
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @aezomz |
69a2c8f
to
f9fae84
Compare
f9fae84
to
4cd498e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing! This looks good! Can we also do similar thing for freshness task?
Also do you think you can look up functional tests that test those two functions and add some test there?(link for freshness, for test maybe add some additional check here?)
How to run functional tests(link). Once you setup you can also just do pytest testfilename.py
Can u share where can I get the adapter response for freshness? I couldn't find it Big thank you for pointing me to the test that i should update with. |
4cd498e
to
cdb6c01
Compare
Seconding, thanks for the contribution @aezomz!
Check out this comment from a few months ago: #2964 (comment) And this commit (though might need some rework given other changes): a066c1e |
cdb6c01
to
8f76389
Compare
@jtcohen6 , thanks for the guidance. I will never figure this out on my own. There is some mypy errors that i suppressed since its returning AttrDict now, feel free to suggest a better way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aezomz Thanks for adding this function to both test and freshness!!! Looks great to me
🎉 thanks @aezomz! |
Add adapter_response for dbt test
resolves #2964
or partial resolve?
Description
Checklist
changie new
to create a changelog entry