-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make seeds ref'able, provide for seed configuration #668
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -125,14 +125,14 @@ def model_immediate_name(model, non_destructive): | |
return "{}__dbt_tmp".format(model_name) | ||
|
||
|
||
def find_model_by_name(flat_graph, target_name, target_package): | ||
def find_refable_by_name(flat_graph, target_name, target_package): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! |
||
return find_by_name(flat_graph, target_name, target_package, | ||
'nodes', NodeType.Model) | ||
'nodes', [NodeType.Model, NodeType.Seed]) | ||
|
||
|
||
def find_macro_by_name(flat_graph, target_name, target_package): | ||
return find_by_name(flat_graph, target_name, target_package, | ||
'macros', NodeType.Macro) | ||
'macros', [NodeType.Macro]) | ||
|
||
|
||
def find_by_name(flat_graph, target_name, target_package, subgraph, | ||
|
@@ -146,7 +146,7 @@ def find_by_name(flat_graph, target_name, target_package, subgraph, | |
|
||
resource_type, package_name, node_name = node_parts | ||
|
||
if (resource_type == nodetype and | ||
if (resource_type in nodetype and | ||
((target_name == node_name) and | ||
(target_package is None or | ||
target_package == package_name))): | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data
is just the default seed data location right? should this beseeds
instead (since the other one ismodels
)?