-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow greater mashumaro versions #7294
Conversation
Current 3.5 is working fine.
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @benallard |
There have been multiple releases of mashumaro that have broken our code. Which means that even a range could be problematic because there could be a version in the range that won't work. We'd have to test with each version in the range... I'm inclined to hard pin it. @benallard Is there some reason you're requesting this? Are you using mashumaro outside of dbt? |
@gsank, I'm packaging dbt for AUR (arch), so we have to rely on the current packaged mashumaro version. The tests worked fine, so I thought that wouldn't be too much of an issue. If there has been breakage in the past, I hope they were documented as test, so we can make sure they don't occur again. That way, we could rely on a relax requirement + working test. Any packager will let the test run within its own environment, so version requirement in the setup.py are in my eyes more like a hint on already tested tested version. Should I better open an issue (which I'll have to do anyway, it seems), to discuss this further, then we can discard this pull-request. |
See #7295 |
For the reasons @gshank described above, we're going to keep |
@benallard We require contributors to sign our Contributor License Agreement -- would you be willing to sign that so we can give you credit for this contribution? |
CLA ✅ |
@benallard Just missing a changelog entry:
|
Yeah, changie ✅ |
Current 3.5 is working fine.
resolves #7295
Description
Checklist
changie new
to create a changelog entry