Reset invocation_id Between Commands #7317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
gshank
approved these changes
Apr 11, 2023
peterallenwebb
commented
Apr 11, 2023
| initialize_from_flags(flags.SEND_ANONYMOUS_USAGE_STATS, flags.PROFILES_DIR) | ||
| ctx.with_resource(track_run(run_command=flags.WHICH)) | ||
|
|
||
| # Logging |
There was a problem hiding this comment.
I had to move logging initialization above tracking because tracking fires events. Those events won't be sent to the right callbacks unless logging is already initialized.
MichelleArk
reviewed
Apr 11, 2023
core/dbt/cli/requires.py
Outdated
| @@ -41,14 +41,15 @@ def wrapper(*args, **kwargs): | |||
| ctx.obj["flags"] = flags | |||
| set_flags(flags) | |||
|
|
|||
| # Tracking | |||
| initialize_from_flags(flags.SEND_ANONYMOUS_USAGE_STATS, flags.PROFILES_DIR) | |||
There was a problem hiding this comment.
does this (sets up active_user) need to happen logger initialization, or just before tracking? If it's only necessary for tracking, let's move it down where tracking is initialized for readability
There was a problem hiding this comment.
Sounds good.
…on_id being stable between runs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #7197
Description
Reset invocation_id between command invocations.
Checklist
changie newto create a changelog entry