Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not merge - testing codeowners #7420

Closed
wants to merge 1 commit into from
Closed

Conversation

MichelleArk
Copy link
Contributor

testing: #7406

Description

Checklist

@cla-bot cla-bot bot added the cla:yes label Apr 20, 2023
@MichelleArk MichelleArk marked this pull request as ready for review April 20, 2023 16:07
@MichelleArk MichelleArk requested a review from a team as a code owner April 20, 2023 16:07
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link
Member

@aranke aranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MichelleArk MichelleArk added the Skip Changelog Skips GHA to check for changelog file label Apr 20, 2023
@MichelleArk
Copy link
Contributor Author

👍 Confirmed that Cloud Artifacts is tagged on these changes, but does not block merge on review, as desired.

Merging blocked before review:
Screen Shot 2023-04-20 at 12 07 58 PM

Review from core team, not in cloud artifacts team:
Screen Shot 2023-04-20 at 1 52 52 PM

Merging unblocked on passing CI checks:
Screen Shot 2023-04-20 at 1 52 36 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants