Update CODEOWNERS to include the OSS Tooling Guild #7472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbloss
reviewed
Apr 27, 2023
| pyproject.toml @dbt-labs/guild-oss-tooling | ||
| requirements.txt @dbt-labs/guild-oss-tooling | ||
| dev_requirements.txt @dbt-labs/guild-oss-tooling | ||
| /core/setup.py @dbt-labs/guild-oss-tooling |
There was a problem hiding this comment.
Should /plugins/postgres/setup.py and /core/MANIFEST.in be in this list too?
I see in the root level requirements.txt a reference to:
./corethat points pip to:/core/setup.py(covered here)/core/MANIFEST.in
./plugins/postgresthat points pip to/plugins/postgres/setup.py
There was a problem hiding this comment.
Good catch! Added.
/plugins/postgres/setup.py is listed below with two owners. The adapters team wants to maintain ownership of the file as well.
leahwicz
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the OSS Tooling Guild to CODEOWNERS. Once we settle on all the files we need to replicate this in the adapter repos. They review should not required but this will help keep us aware of changes made.
Should also add this to, in the least:
dbt-labs/actionsdbt-labs/dbt-releasedbt-labs/homebrew-dbtOpen to any changes to my proposal.
Checklist
changie newto create a changelog entry