-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always write run_results.json
#7539
Merged
iknox-fa
merged 12 commits into
main
from
iknox/CT-2387-GH-7302-always-write-run-results
May 9, 2023
+77
−19
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
6d46eac
writes run_results.json after each node
iknox-fa aaa5599
better class attrs
iknox-fa 55768a6
Fix inconsistant result writing for freshness vs run, respect WRITE_J…
iknox-fa 2f294b9
changelog
iknox-fa 9be134d
fail fast tests for run_results.json
iknox-fa dc92aa1
terminate process testing
iknox-fa ffe9f53
better comments
iknox-fa 0b53d3f
new test approach
iknox-fa dcd73e5
Janky test gets Jankier
iknox-fa 064e774
Janky test gets Jankier
iknox-fa 64756b9
PR feedback
iknox-fa 606aac2
lcase is preferred
iknox-fa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
better class attrs
commit aaa5599ebcbace90fd1b6fc0c40b754ce1d74722
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self.started
is the only new value here. The rest of the changes are just sorting things for readability.