Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not equals comparison to be null-safe for adapters/utils tests #7776

Merged
merged 7 commits into from
Jun 6, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix names within functional test
dbeatty10 committed Jun 4, 2023
commit 1a3d98df602f05628f9d98635bb9065c7499e81e
Original file line number Diff line number Diff line change
@@ -8,7 +8,7 @@
MODELS__TEST_MIXED_NULL_COMPARE_YML = """
version: 2
models:
- name: test_null_compare
- name: test_mixed_null_compare
tests:
- assert_equal:
actual: actual
6 changes: 3 additions & 3 deletions tests/adapter/dbt/tests/adapter/utils/test_null_compare.py
Original file line number Diff line number Diff line change
@@ -14,8 +14,8 @@ class BaseMixedNullCompare(BaseUtils):
@pytest.fixture(scope="class")
def models(self):
return {
"test_mixed_null_compare.yml": MODELS__TEST_MIXED_NULL_COMPARE_SQL,
"test_mixed_null_compare.sql": MODELS__TEST_MIXED_NULL_COMPARE_YML,
"test_mixed_null_compare.yml": MODELS__TEST_MIXED_NULL_COMPARE_YML,
"test_mixed_null_compare.sql": MODELS__TEST_MIXED_NULL_COMPARE_SQL,
dbeatty10 marked this conversation as resolved.
Show resolved Hide resolved
}

def test_build_assert_equal(self, project):
@@ -32,7 +32,7 @@ def models(self):
}


class TestMixedNullCompare(BaseNullCompare):
class TestMixedNullCompare(BaseMixedNullCompare):
pass