-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added "Referenced By" and "Depends On" section for each SQL file #106
Changes from 8 commits
6873bdb
a413f1a
1a282b9
4698f1a
c1e6aff
76dc447
bf574c8
b1c53b0
39345e5
4f86531
e7c984b
e1662ca
ca1b145
d023bb5
522207d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
GEM | ||
remote: https://rubygems.org/ | ||
specs: | ||
addressable (2.7.0) | ||
public_suffix (>= 2.0.2, < 5.0) | ||
colorator (1.1.0) | ||
concurrent-ruby (1.1.6) | ||
em-websocket (0.5.1) | ||
eventmachine (>= 0.12.9) | ||
http_parser.rb (~> 0.6.0) | ||
eventmachine (1.2.7) | ||
ffi (1.13.1) | ||
forwardable-extended (2.6.0) | ||
http_parser.rb (0.6.0) | ||
i18n (0.9.5) | ||
concurrent-ruby (~> 1.0) | ||
jekyll (3.8.7) | ||
addressable (~> 2.4) | ||
colorator (~> 1.0) | ||
em-websocket (~> 0.5) | ||
i18n (~> 0.7) | ||
jekyll-sass-converter (~> 1.0) | ||
jekyll-watch (~> 2.0) | ||
kramdown (~> 1.14) | ||
liquid (~> 4.0) | ||
mercenary (~> 0.3.3) | ||
pathutil (~> 0.9) | ||
rouge (>= 1.7, < 4) | ||
safe_yaml (~> 1.0) | ||
jekyll-sass-converter (1.5.2) | ||
sass (~> 3.4) | ||
jekyll-watch (2.2.1) | ||
listen (~> 3.0) | ||
kramdown (1.17.0) | ||
liquid (4.0.3) | ||
listen (3.2.1) | ||
rb-fsevent (~> 0.10, >= 0.10.3) | ||
rb-inotify (~> 0.9, >= 0.9.10) | ||
mercenary (0.3.6) | ||
pathutil (0.16.2) | ||
forwardable-extended (~> 2.6) | ||
public_suffix (4.0.5) | ||
rb-fsevent (0.10.4) | ||
rb-inotify (0.10.1) | ||
ffi (~> 1.0) | ||
rouge (3.20.0) | ||
safe_yaml (1.0.5) | ||
sass (3.7.4) | ||
sass-listen (~> 4.0.0) | ||
sass-listen (4.0.0) | ||
rb-fsevent (~> 0.9, >= 0.9.4) | ||
rb-inotify (~> 0.9, >= 0.9.7) | ||
|
||
PLATFORMS | ||
ruby | ||
|
||
DEPENDENCIES | ||
jekyll (~> 3.8) | ||
|
||
BUNDLED WITH | ||
2.1.4 |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -36,6 +36,8 @@ <h1> | |
<li ui-sref-active='active'><a ui-sref="dbt.model({'#': 'details'})">Details</a></li> | ||
<li ui-sref-active='active'><a ui-sref="dbt.model({'#': 'description'})">Description</a></li> | ||
<li ui-sref-active='active'><a ui-sref="dbt.model({'#': 'columns'})">Columns</a></li> | ||
<li ui-sref-active='active'><a ui-sref="dbt.model({'#': 'referenced_by'})">Referenced By</a></li> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can and should figure out a better way to reduce the copy/paste necessary for these different node types. Not a problem at all for right now though :) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sounds good! Let me know if you would like me to spend some time on figuring out how to reduce the copy pasting. |
||
<li ui-sref-active='active'><a ui-sref="dbt.model({'#': 'depends_on'})">Depends On</a></li> | ||
<li ui-sref-active='active'><a ui-sref="dbt.model({'#': 'code'})">SQL</a></li> | ||
</ul> | ||
</div> | ||
|
@@ -68,6 +70,22 @@ <h6>Columns</h6> | |
</div> | ||
</section> | ||
|
||
<section class="section"> | ||
<div class="section-target" id="referenced_by"></div> | ||
<div class="section-content"> | ||
<h6>Referenced By</h6> | ||
<reference-list references="references" /> | ||
</div> | ||
</section> | ||
|
||
<section class="section"> | ||
<div class="section-target" id="depends_on"></div> | ||
<div class="section-content"> | ||
<h6>Depends On</h6> | ||
<reference-list references="parents" /> | ||
</div> | ||
</section> | ||
|
||
<section class="section"> | ||
<div class="section-target" id="code"></div> | ||
<div class="section-content"> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think there's a way to reconcile this logic with the code in
src/app/docs/utils.js
? I totally get that the different namespaces for macros and nodes could make this challenging, but it feels funny to have two very similar sets of functions so far apart from each other. Let me know what you think!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The decision to include these two functions in
macro.js
and separate fromutils.js
was to accommodate for the differing properties of macros and nodes. Would it make sense to you to have the two functions inmacro.js
included inutils.js
as well?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drewbanin I moved the functions related to obtaining references and parents for macros from
macro.js
todag_utils.js
(previously utils.js). Let me know what you think.