Remove tag exclusion from exposures #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtcohen6
reviewed
Jun 7, 2021
There was a problem hiding this comment.
@stkbailey Looks great, thanks!
As far as the changelog, I just updated to reflect the 0.20.0rc1 release. Can you:
- Pull latest
master - Add an entry below
## dbt 0.20.0 (Release TBD) - Move your name to a new Contributors list below
## dbt 0.20.0 (Release TBD)
* Merge upstream docs changes * add meta information from sources to be picked up by rendering too * Update CHANGELOG.md * Update Changelog Co-authored-by: Diëgo De Wilde <[email protected]> Co-authored-by: Jeremy Cohen <[email protected]> * Update changelog Co-authored-by: Diëgo De Wilde <[email protected]> Co-authored-by: Jeremy Cohen <[email protected]>
|
I think this is set now @jtcohen6 ... git got a little sloppy though 😭 |
jtcohen6
approved these changes
Jun 9, 2021
There was a problem hiding this comment.
All good! Thanks so much for this @stkbailey. The meta + tag names in your sample/screenshot brought a smile to my face :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #194
Description
This PR removes the exclusion of tags from the exposure docs. This is now allowed due to a PR to dbt enabling tags and meta on exposures. dbt-labs/dbt-core#3405
Example result is below (jaffle_shop):
Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.