Fix docs generation integration test #70
Conversation
… result of core PR 4618.
VersusFacit
changed the title
|
@leahwicz Thanks for the pointer on consulting core merges as part of the debugging process. Got Redshift tests happy again with a touch of debugging following the read through of the Core PR! I'll be sure to follow that process in the future should "random" bugs arise |
| @@ -183,6 +183,7 @@ def assert_has_keys( | |||
| 'invocation_id', | |||
| 'modules', | |||
| 'flags', | |||
| 'print' | |||
There was a problem hiding this comment.
Was this addition needed b/c of this PR dbt-labs/dbt-core#4701?
There was a problem hiding this comment.
If so, I'm guessing the other adapters might need this update as well
There was a problem hiding this comment.
It was. I'll merge this PR and look at the others
There was a problem hiding this comment.
Doubled checked snowflake, bigquery, and spark. The unit tests of those are passing just fine! No additional fixes needed for this issue looks like. 😄
VersusFacit
deleted the
CT-213/correct_docs_generation_int_test_catalogs
branch
* Add unique_key field to config sections where it is now expected as a result of core PR 4618. * Remove duplicate key. * Fix unit test bug introduced by merge of dbt-core PR 4701. Co-authored-by: Mila Page <[email protected]>
Resolves bug to an integration test introduced by merge of multiple unique ids for integration tests
Description
The test diffs a pair of configs, in which must be certain parameters. Changes to core have necessitated the addition of
unique_idto two configs in this test.Note:
Although this PR is small, it represents the same contextual work done with the matching Snowflake fix.
Checklist
CHANGELOG.mdand added information about my change to the "dbt-snowflake next" section.