Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new SavedQuery protocol #144

Closed
Tracked by #140
QMalcolm opened this issue Sep 7, 2023 · 0 comments · Fixed by #148
Closed
Tracked by #140

Add new SavedQuery protocol #144

QMalcolm opened this issue Sep 7, 2023 · 0 comments · Fixed by #148
Assignees
@plypaul
Labels
enhancement New feature or request Needs Refinement

Comments

@QMalcolm
Copy link
Collaborator

QMalcolm commented Sep 7, 2023 •
edited
Loading

In dbt-labs/metricflow#765 new functionality for saved queries will be introduced in MetricFlow. To support this we need to extend the SemanticManifest protocol to have a new top level attribtue saved_queries which will be a sequence of SavedQuery protocols.

The SavedQuery protocol will need to have the following attributes

  • name a string
  • description an optional string
  • query a sub protocol Query

The Query protocol will need to have the following attributes

  • metrics an (optional?) list of metrics
  • group_bys an (optional?) list of ?
  • where an (optional?) ?
  • limit an (optional?) integer
  • order an (optional?) ?
@QMalcolm QMalcolm mentioned this issue Sep 7, 2023
Closed
@QMalcolm QMalcolm changed the title Add new save_query protocol definition Add new saved_query protocol definition Sep 7, 2023
@QMalcolm QMalcolm added enhancement New feature or request Needs Refinement labels Sep 7, 2023
@QMalcolm QMalcolm changed the title Add new saved_query protocol definition Add new SavedQuery protocol Sep 7, 2023
@QMalcolm QMalcolm mentioned this issue Sep 8, 2023
Closed
plypaul added a commit that referenced this issue Sep 14, 2023
@plypaul
Add change log for #144
9d81690
@plypaul plypaul mentioned this issue Sep 14, 2023
Merged
4 tasks
plypaul added a commit that referenced this issue Sep 14, 2023
@plypaul
Add change log for #144
57df3a2
plypaul added a commit that referenced this issue Sep 19, 2023
@plypaul
Add change log for #144
37c96f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plypaul plypaul

Labels
enhancement New feature or request Needs Refinement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add New SavedQuery Protocol dbt-labs/dbt-semantic-interfaces
2 participants
@plypaul @QMalcolm