Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

remove any leftover inline node before compile #248

Merged
merged 1 commit into from
Oct 23, 2023
Merged

remove any leftover inline node before compile #248

merged 1 commit into from
Oct 23, 2023

Conversation

ChenyuLInx
Copy link
Contributor

What is this PR?

This is a:

  • documentation update
  • bug fix with no breaking changes
  • new functionality
  • a breaking change

All pull requests from community contributors should target the main branch (default).

Description & motivation

Checklist

  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
    • Databricks
    • Spark
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models
  • I have added an entry to CHANGELOG.md

@cla-bot cla-bot bot added the cla:yes label Oct 23, 2023
@github-actions
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

1 similar comment
@github-actions
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

DevonFulcher
DevonFulcher reviewed Oct 23, 2023
View reviewed changes
Copy link
Contributor

@DevonFulcher DevonFulcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we may want to get Rachel's approval too

@cesher cesher requested a review from drewbanin October 23, 2023 20:00
racheldaniel
racheldaniel approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@racheldaniel racheldaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ChenyuLInx ChenyuLInx merged commit 5f4744f into main Oct 23, 2023
@ChenyuLInx ChenyuLInx deleted the remove-inline-node-if-exist branch October 23, 2023 20:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DevonFulcher DevonFulcher DevonFulcher left review comments

@racheldaniel racheldaniel racheldaniel approved these changes

@cesher cesher cesher approved these changes

@drewbanin drewbanin Awaiting requested review from drewbanin

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChenyuLInx @cesher @DevonFulcher @racheldaniel