Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snowflake_ocsp_insecure_mode: Expose the insecure_mode python option … #30

Closed

Conversation

JoshuaHuntley
Copy link
Contributor

@JoshuaHuntley JoshuaHuntley commented Oct 19, 2021

…to dbt.

resolves #31
Resolves issues when the Snowflake OCSP server is not reachable and the dbt user would like to run commands without checking the OCSP server. OCSP failures/inaccessibilitiy are possible due to network routing issues or when corporate network security has exposed Snowflake (especially in privatelink) but not the OCSP server.

Description

Exposes the insecure_mode option in the Snowflake python connector to dbt via the profile.yml file.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt-snowflake next" section.

@cla-bot cla-bot bot added the cla:yes label Oct 19, 2021
@jtcohen6
Copy link
Contributor

@JoshuaHuntley Do you mind opening an issue outlining the problem that this PR seeks to solve? In which cases is the Snowflake OCSP server not reachable?

Also — it looks like you're reverting some changes to transactional logic, in connections.py, that we made in v0.21. I'm not sure if that's intended, or left over from resolving a git conflict.

@JoshuaHuntley
Copy link
Contributor Author

JoshuaHuntley commented Oct 20, 2021

@JoshuaHuntley Do you mind opening an issue outlining the problem that this PR seeks to solve? In which cases is the Snowflake OCSP server not reachable?

Also — it looks like you're reverting some changes to transactional logic, in connections.py, that we made in v0.21. I'm not sure if that's intended, or left over from resolving a git conflict.

Hi @jtcohen6 ,

I've opened an issue outlining the problem and linked it in this PR.

Regarding your question, this PR only inserts two lines of code, both beginning with "insecure_mode". Anything else is a merge conflict. When I checked, Git said that "This branch is up to date with dbt-labs:main." .

@jtcohen6
Copy link
Contributor

jtcohen6 commented Nov 3, 2021

@JoshuaHuntley I do see some unrelated changes included in the commit: fffc4dd

Any chance you could try rebasing this PR, or close it and open a new one? It sounds like the actual change you want is a two-liner, just adding insecure_mode to SnowflakeCredentials and the call to snowflake.connector.connect.

@JoshuaHuntley JoshuaHuntley force-pushed the snowflake_ocsp_insecure_mode branch from fffc4dd to 79d7818 Compare November 4, 2021 22:19
@jtcohen6
Copy link
Contributor

jtcohen6 commented Nov 7, 2021

I'm not sure why 79d7818 continues to include the other unrelated changes. It might be simpler to open a new PR.

Rebasing these changes on the upstream branch
@JoshuaHuntley
Copy link
Contributor Author

@jtcohen6 Was out on paternity leave and got back today. Tried to fix the branch and it looks like I was successful. Will continue to monitor for feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure to resolve Snowflake OCSP server creates issues with dbt
2 participants