Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

empty indirect selection mode #3404

Closed
1 task done
dbeatty10 opened this issue May 21, 2023 · 0 comments · Fixed by #3738
Closed
1 task done

empty indirect selection mode #3404

dbeatty10 opened this issue May 21, 2023 · 0 comments · Fixed by #3738
Assignees
@nghi-ly
Labels
content Improvements or additions to content dbt-core v1.5 Docs impact for the v1.5 release (Apr 2023) improvement Use this when an area of the docs needs improvement as it's currently unclear
Milestone
dbt Core v1.5 Doc...

Comments

@dbeatty10
Copy link
Contributor

Contributions

  • I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates

https://docs.getdbt.com/reference/node-selection/yaml-selectors (and probably others as well).

Basically, empty should be added wherever buildable appears.

What part(s) of the page would you like to see updated?

v1.5 added a new empty mode for indirect selection in dbt-labs/dbt-core#7008, but it hasn't been documented yet.

See here for a brief explanation.

Additional information

No response
@dbeatty10 dbeatty10 added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear labels May 21, 2023
@jtcohen6 jtcohen6 added the dbt-core v1.5 Docs impact for the v1.5 release (Apr 2023) label May 25, 2023
@jtcohen6 jtcohen6 added this to the dbt Core v1.5 Documentation milestone Jun 20, 2023
@nghi-ly nghi-ly self-assigned this Jul 13, 2023
@nghi-ly nghi-ly mentioned this issue Jul 13, 2023
Merged
2 tasks
nghi-ly added a commit that referenced this issue Jul 25, 2023
@nghi-ly
New empty mode for indirect selection (#3738)
cd6a893 
## What are you changing in this pull request and why?

For v1.5, `indirect_selection` includes a new `empty` mode. Add docs for
the new mode.

Ran a search on the docs.getdbt.com repo and found these instances of
`buildable` (where `empty` should be added):
https://github.com/search?q=repo%3Adbt-labs%2Fdocs.getdbt.com+buildable&type=code
. So updated these pages:

-
https://docs.getdbt.com/reference/node-selection/test-selection-examples#indirect-selection
- https://docs.getdbt.com/reference/node-selection/yaml-selectors

Resolves #3404 

## Checklist
- [x] Review the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md)
and [About
versioning](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#adding-a-new-version)
so my content adheres to these guidelines.
- [ ] Needs review from product team
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nghi-ly nghi-ly

Labels
content Improvements or additions to content dbt-core v1.5 Docs impact for the v1.5 release (Apr 2023) improvement Use this when an area of the docs needs improvement as it's currently unclear
Projects
None yet
Milestone
dbt Core v1.5 Documentation
Development

Successfully merging a pull request may close this issue.

New empty mode for indirect selection dbt-labs/docs.getdbt.com
3 participants
@jtcohen6 @dbeatty10 @nghi-ly