Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross database type_{X} macros #1648

Merged
merged 5 commits into from
Jul 5, 2022

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Jun 30, 2022

Description & motivation

Resolves #1644

To-do before merge

Prerelease docs

If this change is related to functionality in a prerelease version of dbt (delete if not applicable):

@netlify
Copy link

netlify bot commented Jun 30, 2022

Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit 2608f8c
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/62bdc1376064df0009544b4c
😎 Deploy Preview https://deploy-preview-1648--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the content Improvements or additions to content label Jun 30, 2022
@dbeatty10 dbeatty10 requested a review from jtcohen6 June 30, 2022 15:29
@github-actions github-actions bot added the size: medium This change will take up to a week to address label Jun 30, 2022
@dbeatty10 dbeatty10 marked this pull request as ready for review June 30, 2022 15:30
Copy link
Contributor

@dataders dataders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few questions:

  1. is it worth having a sidebar entry for each of the newly added macros, even if they just link to subheading on this page? It's a non-blocking issue, but my gut tells me the sidebar could be more helpful? Perhaps @gwenwindflower has some incremental guidance for us...

image

  1. what is the intent behind the "SQL Expressions" section at the bottom is it linked from elsewhere?

@dbeatty10
Copy link
Contributor Author

  1. is it worth having a sidebar entry for each of the newly added macros?

I'm not sure 🤷 Definitely interested in any feedback and ideas from you, @gwenwindflower, and others.

  1. what is the intent behind the "SQL Expressions" section at the bottom is it linked from elsewhere?

Yep, it is linked many, many times right now since expressions are a little tricky to explain and understand:

Example:

  • image

Were you thinking it should live (or link) somewhere else?

@dbeatty10 dbeatty10 merged commit 8a04e8d into current Jul 5, 2022
@dbeatty10 dbeatty10 deleted the dbeatty/cross-database-type-X-macros branch July 5, 2022 16:41
@dataders
Copy link
Contributor

dataders commented Jul 5, 2022

Were you thinking it should live (or link) somewhere else?

perhaps a standalone page? idc

@dbeatty10
Copy link
Contributor Author

@dataders I merged this to get it out the door prior to the release candidate. But definitely feel free to re-organize by moving that section to a stand-alone page somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add type_{X} macros to listing of cross-database macros
3 participants