-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cross database type_{X}
macros
#1648
Conversation
✅ Deploy Preview for docs-getdbt-com ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few questions:
- is it worth having a sidebar entry for each of the newly added macros, even if they just link to subheading on this page? It's a non-blocking issue, but my gut tells me the sidebar could be more helpful? Perhaps @gwenwindflower has some incremental guidance for us...
- what is the intent behind the "SQL Expressions" section at the bottom is it linked from elsewhere?
I'm not sure 🤷 Definitely interested in any feedback and ideas from you, @gwenwindflower, and others.
Yep, it is linked many, many times right now since expressions are a little tricky to explain and understand: Were you thinking it should live (or link) somewhere else? |
perhaps a standalone page? idc |
@dataders I merged this to get it out the door prior to the release candidate. But definitely feel free to re-organize by moving that section to a stand-alone page somewhere. |
Description & motivation
Resolves #1644
To-do before merge
Prerelease docs
If this change is related to functionality in a prerelease version of dbt (delete if not applicable):