Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial documentation for thread_id context variable #3729

Merged
merged 4 commits into from
Jul 14, 2023
Merged

Initial documentation for thread_id context variable #3729

merged 4 commits into from
Jul 14, 2023

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Jul 13, 2023 •
edited
Loading

resolves #3614

Preview

What are you changing in this pull request and why?

dbt-labs/dbt-core#7942 / dbt-labs/dbt-core#7941

This new thread_id context variable works in query tags because it's set by the (Python) worker thread.

Utility

Comment:

@NiallRees you're my hero.

https://getdbt.slack.com/archives/C2JRRQDTL/p1656203829761049

🎩

image

Checklist

  • Add versioning components, as described in Versioning Docs
  • Add a note to the prerelease version Migration Guide
  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Confirm that the bullet points are actually true
  • Add page to website/sidebars.js didn't do this because it appeared unecessary
  • Provide a unique filename for the new page

@netlify
Copy link

netlify bot commented Jul 13, 2023 •
edited
Loading

✅ Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit accec0f
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/64b152c8f16df90008f2ac32
😎 Deploy Preview https://deploy-preview-3729--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address labels Jul 13, 2023
@dbeatty10
Copy link
Contributor Author

@NiallRees would you be willing to give this preview a look and provide feedback?

@NiallRees
Copy link
Contributor

Looks great @dbeatty10 !

@dbeatty10 dbeatty10 marked this pull request as ready for review July 14, 2023 12:51
@dbeatty10 dbeatty10 requested a review from a team as a code owner July 14, 2023 12:51
mirnawong1
mirnawong1 approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @dbeatty10 ! this looks awesome, left a non blocker suggestion and approved for you to :mergedparrot: (lol)

@dbeatty10 dbeatty10 enabled auto-merge (squash) July 14, 2023 13:51
@dbeatty10 dbeatty10 merged commit 1455c27 into current Jul 14, 2023
@dbeatty10 dbeatty10 deleted the dbeatty/thread-id branch July 14, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document thread_id context var
3 participants
@dbeatty10 @NiallRees @mirnawong1