Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQuery authorized views #414

Merged
merged 1 commit into from
Oct 13, 2020
Merged

BigQuery authorized views #414

merged 1 commit into from
Oct 13, 2020

Conversation

jtcohen6
Copy link
Collaborator

Description & motivation

Pre-release docs

Is this change related to an unreleased version of dbt?

  • Yes: please
    • update the base branch to next
    • add Changelog components: <Changelog>[New/Changed] in v0.x.0</Changelog>
    • add links to the "New and changed documentation" section of the latest Migration Guide
  • No: please ensure the base branch is current
  • Unsure: we'll let you know!

@jtcohen6 jtcohen6 requested a review from clrcrl as a code owner October 13, 2020 20:48
@jtcohen6 jtcohen6 force-pushed the feature/bq-auth-views branch from 1d261d3 to 241446a Compare October 13, 2020 20:48
@jtcohen6
Copy link
Collaborator Author

@azhard Would you mind giving this a once-over, if you have a moment? Want to make sure I'm saying roughly the right things :)

Copy link
Contributor

@clrcrl clrcrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@azhard
Copy link

azhard commented Oct 13, 2020

@azhard Would you mind giving this a once-over, if you have a moment? Want to make sure I'm saying roughly the right things :)

LGTM!

@jtcohen6 jtcohen6 merged commit e2ebb7f into current Oct 13, 2020
@jtcohen6 jtcohen6 deleted the feature/bq-auth-views branch October 13, 2020 21:21
@azhard
Copy link

azhard commented Oct 14, 2020

Hey @jtcohen6 hate to do this post merge but realized a slight problem with the SQL config, the project and dataset keys need to be quoted like so:

{{ config(
    grant_access_to=[
+      {'project': 'project_1', 'dataset: 'dataset_1'},
+      {'project': 'project_2', 'dataset': 'dataset_2'}
-      {project: 'project_1', dataset: 'dataset_1'},
-      {project: 'project_2', dataset: 'dataset_2'}
    ]
) }}

Apologies for not catching that the first time!

1 similar comment
@azhard
Copy link

azhard commented Oct 14, 2020

Hey @jtcohen6 hate to do this post merge but realized a slight problem with the SQL config, the project and dataset keys need to be quoted like so:

{{ config(
    grant_access_to=[
+      {'project': 'project_1', 'dataset: 'dataset_1'},
+      {'project': 'project_2', 'dataset': 'dataset_2'}
-      {project: 'project_1', dataset: 'dataset_1'},
-      {project: 'project_2', dataset: 'dataset_2'}
    ]
) }}

Apologies for not catching that the first time!

@jtcohen6
Copy link
Collaborator Author

@azhard All good, thank you so much for catching!

nghi-ly pushed a commit that referenced this pull request Feb 13, 2024
REPO SYNC - Public to Private
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants