Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SL-3300] [Bug] dbt-core dependency issue with metricflow==0.207.0 #1632

Open
2 tasks done
plypaul opened this issue Jan 24, 2025 · 0 comments
Open
2 tasks done

[SL-3300] [Bug] dbt-core dependency issue with metricflow==0.207.0 #1632

plypaul opened this issue Jan 24, 2025 · 0 comments
Assignees
Labels
bug Something isn't working triage Tasks that need to be triaged

Comments

@plypaul
Copy link
Contributor

plypaul commented Jan 24, 2025

Is this a new bug in metricflow?

  • I believe this is a new bug in metricflow
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

The metricflow==0.207.0 package is not compatible with the latest release of dbt-core~=1.9 so upgrading to 0.207.0 gives the following error with an mf command:

ImportError: cannot import name 'SqlBindParameters' from 'metricflow_semantics.sql.sql_bind_parameters'

Expected Behavior

Any mf command e.g. mf tutorial will throw the error.

Steps To Reproduce

Run mf tutorial

Relevant log output

Environment

- metricflow: 0.207.0

Which database are you using?

No response

Additional Context

No response

SL-3300

@plypaul plypaul added bug Something isn't working triage Tasks that need to be triaged labels Jan 24, 2025
@plypaul plypaul self-assigned this Jan 24, 2025
@plypaul plypaul changed the title [Bug] dbt-core dependency issue with metricflow==0.207.0 [SL-3300] [Bug] dbt-core dependency issue with metricflow==0.207.0 Jan 24, 2025
plypaul added a commit that referenced this issue Jan 25, 2025
Resolves #1589
Resolves #1632 

* The previous release `0.207.0` was not compatible with `dbt-core=1.9`
as the requirement for `dbt-semantic-interfaces` in both packages was
different.
* To address this, I've cut a branch `release-0.207.1` from commit
`5bb13511d36c6122527a1bd12de9d6e0707a9ddc`, which seems to be the last
version before the dependency requirement for `dbt-semantic-interfaces`
changed in `metricflow`.
* The requirement for `dbt-semantic-interfaces` was previously pinned to
`0.7.2` - I'm looking for context on the strict pin.
* For now, I've updated the requirement to
`dbt-semantic-interfaces>=0.7.4,<0.8`. `0.7.4` was the lowest version
compatible with `dbt-core=1.9`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Tasks that need to be triaged
Projects
None yet
Development

No branches or pull requests

1 participant