fixup! fix: serialization issues in GraphQL orderBy and where

dbt-labs · Nov 11, 2024 · 59ccc71 · 59ccc71
1 parent e445a09
commit 59ccc71
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/tests/query_test_cases.py b/tests/query_test_cases.py
@@ -17,6 +17,11 @@
     {
         "metrics": ["order_total"],
     },
+    # ad hoc query, metric and group by
+    {
+        "metrics": ["order_total"],
+        "group_by": ["customer__customer_type"],
+    },
     # saved query, all parameters
     {
         "saved_query": "order_metrics",

diff --git a/tests/test_models.py b/tests/test_models.py
@@ -223,6 +223,15 @@ def test_validate_query_params_adhoc_query_no_metrics() -> None:
         validate_query_parameters(p)
 
 
+def test_validate_query_params_saved_query_group_by() -> None:
+    p: QueryParameters = {
+        "saved_query": "sq",
+        "group_by": ["a", "b"],
+    }
+    with pytest.raises(ValueError):
+        validate_query_parameters(p)
+
+
 def test_validate_query_params_adhoc_and_saved_query() -> None:
     p: QueryParameters = {"metrics": ["a", "b"], "group_by": ["a", "b"], "saved_query": "a"}
     with pytest.raises(ValueError):