fix: import error on 3.9 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous version of the package was raising errors on Python 3.9 due to importing `Self` from `typing`, which was introduced in 3.10. I changed it to `typing_extensions`, and added a test for importing all modules to avoid errors like this in the future.
serramatutu
force-pushed
the
serramatutu/fix-import
branch
9 times, most recently
from
576022c to
a7dce57
Compare
serramatutu
force-pushed
the
serramatutu/fix-import
branch
from
a7dce57 to
4dc593a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version of the package was raising errors on Python 3.9 due to importing
Selffromtyping, which was introduced in 3.10. I changed it totyping_extensions, and added a test for importing all modules to avoid errors like this in the future.