Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump singer-python from <5.2.0 to <5.5.0 #7

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

jtcohen6
Copy link
Contributor

@bthomson22
Copy link

cc @epapineau as this aligns with your need for singer-python==5.4.0

@epapineau
Copy link
Contributor

@jtcohen6 @cmcarthur and / or @drewbanin any objections on merging this change in? 🙏🏻

@cmcarthur
Copy link
Member

@epapineau were you able to test this change in any way to make sure it doesn't break tap-framework?

the change itself looks okay

@epapineau
Copy link
Contributor

@cmcarthur I am successfully running a tap using a local tap-framework setup.py as:

          'singer-python>=5.4.0,<5.5.0',

I specifically need this change to enable ingesting objects.

@bthomson22
Copy link

bthomson22 commented Oct 3, 2022

@cmcarthur @drewbanin we tested this locally on several of our taps and everything worked as expected. If we need to expand testing beyond this we will need some guidance from the both/one of you. I do see that there are several dependencies on this package built by other orgs.

Of note - from an internal perspective, our taps are largely pinned to a specific version of tap-framework, not a range, so internally we will be good to go. We'll update this following the merge, but there are no immediate red flags.

@cmcarthur cmcarthur self-requested a review October 3, 2022 20:43
@cmcarthur
Copy link
Member

approved from my end.

@epapineau epapineau merged commit 1345d49 into master Oct 3, 2022
@epapineau
Copy link
Contributor

@cmcarthur can we assist with getting the release on pypi ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants