add CI #60
add CI #60
Conversation
|
finally got CircleCI up and running, but one test out of 8 is failing... |
|
Does this work for SQL Server? |
This is also the only test that is run. The other are commented out? |
Whoops. I was running just the failing test in order to better document #61. running again now. Can you see the current CI run? |
…nto ci_for_sqlserver
|
CI is passing the 6/8 integration tests in scope for this PR. The other two tests are related to #61 and #26 |
|
I'll merge this in an other branch and test it out :-) |
|
I managed to confuse myself with the git branch, commit etc... Why is it so hard to learn and remember all that stuff? I love git but I also hate it :-) |
| # still confused whether to use "Yes", "yes", "True", or "true" | ||
| # to learn more visit | ||
| # https://docs.microsoft.com/en-us/sql/relational-databases/native-client/features/using-encryption-without-validation?view=sql-server-ver15 | ||
| if getattr(credentials, "encrypt", False) is True: | ||
| con_str.append(f"Encrypt=Yes") | ||
| if getattr(credentials, "trust_cert", False) is True: | ||
| con_str.append(f"TrustServerCertificate=Yes") |
There was a problem hiding this comment.
@mikaelene, I think @NandanHegde15 and I figured it out.
not getattr(credentials, "encrypt", False) currently evaluates to False no matter what string was passed to the encrypt param in the profiles.yml. Because any string evaluates to True.
Our fix was to make encrypt and trust_cert both boolean values. it should now work for you if you don't specify these in your profile.
#this prints
if "no!":
print("foobar")
|
@mikaelene I think we fixed the scenario in which a user doesn't specify |
| ### Security | ||
| Encryption is not enabled by default, unless you specify it. | ||
|
|
||
| To enable encryption, add the following to your target definition. This is the default encryption strategy recommended by MSFT. For more information see [this docs page](https://docs.microsoft.com/en-us/dotnet/framework/data/adonet/connection-string-syntax#using-trustservercertificate?WT.mc_id=DP-MVP-5003930) | ||
| ```yaml | ||
| encrypt: true # adds "Encrypt=Yes" to connection string | ||
| trust_cert: false | ||
| ``` | ||
| For a fully-secure, encrypted connection, you must enable `trust_cert: false` because `"TrustServerCertificate=Yes"` is default for `dbt-sqlserver` in order to not break already defined targets. |
There was a problem hiding this comment.
@NandanHegde15 what do you think of this explanation?
EncryptandTrustServerCertificateparams to be'Yes'but they are defined as bools inprofiles.yml