Healthcheck timeout #209
Merged
Healthcheck timeout #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently a container that has failed to launch completely and is dead will still be checked for the whole timeout period whether it is healthy. This is pointless, as it will not be restarted by itself. Hence we fail early now. This fixes #207
The timeouts were formatted in a hardly readable way, now seconds are printed out instead
dcermak
force-pushed
the
healthcheck-timeout
branch
from
4b37566 to
775598d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #209 +/- ##
==========================================
+ Coverage 94.91% 94.93% +0.01%
==========================================
Files 9 9
Lines 1102 1105 +3
Branches 228 229 +1
==========================================
+ Hits 1046 1049 +3
Misses 42 42
Partials 14 14 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.